[13.x] Use generic TModel in additional places in Factory class#59780
Merged
taylorotwell merged 1 commit intolaravel:13.xfrom Apr 20, 2026
Merged
[13.x] Use generic TModel in additional places in Factory class#59780taylorotwell merged 1 commit intolaravel:13.xfrom
taylorotwell merged 1 commit intolaravel:13.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some of my own overrides I was recently faced with static errors like
Parameter #1 $results of method Illuminate\Database\Eloquent\Factories\Factory<TModel of Illuminate\Database\Eloquent\Model>::store() expects Illuminate\Support\Collection<int, Illuminate\Database\Eloquent\Model>, Illuminate\Support\Collection<int, TModel of Illuminate\Database\Eloquent\Model> given.. Given theTModeltypehint is correct for these places AFAICS, I suggest adding them there.