Skip to content

[13.x] Add enum support to NotificationChannelManager channel and driver methods#59783

Merged
taylorotwell merged 1 commit intolaravel:13.xfrom
yousefkadah:add-enum-support-to-notification-channel-manager
Apr 21, 2026
Merged

[13.x] Add enum support to NotificationChannelManager channel and driver methods#59783
taylorotwell merged 1 commit intolaravel:13.xfrom
yousefkadah:add-enum-support-to-notification-channel-manager

Conversation

@yousefkadah
Copy link
Copy Markdown
Contributor

@yousefkadah yousefkadah commented Apr 20, 2026

Summary

This PR adds enum support to NotificationChannelManager, completing the remaining manager in the enum support wave. This follows the exact pattern from the merged precedents: #59637 (CacheManager), #59645 (MailManager), and #59646 (AuthManager).

Changes

  • Added enum_value() normalization to channel(), driver(), and deliverVia() methods
  • Updated phpdocs to reflect \\UnitEnum|string|null parameter types
  • Added 3 test methods verifying enum and string resolve to the same instance

@taylorotwell taylorotwell merged commit 95891fa into laravel:13.x Apr 21, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants