[13.x] Introduce WorkerInterrupted event#59848
Merged
taylorotwell merged 5 commits intolaravel:13.xfrom Apr 27, 2026
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a signal arrives from infra, the worker finishes the current job before stopping cleanly so we rely on the
WorkerStoppingevent.But, a worker is not guaranteed to finish a job before it's killed from infra.
So, my idea of a
WorkerInterruptedevent is born!This is basically nice from an observability view.
This complements the Interruptible job stuff, essentially. IE I want to know my workers are being signaled, but the jobs may not need to care. I can then log, call Slack etc when a signal arrives so its no longer guess work
Open to renaming it to WorkerSignaled or something if you prefer :)
No test cause its signals.. but can do a fake test if you want?
I've just done it inline, same as WorkerStopping rather than making an executeX method
I think I've done it in a non-bc way, but also:
So forgive me!