[12.x] Narrow attachment url scheme#60035
Merged
Merged
Conversation
shaedrich
reviewed
May 7, 2026
| * Create a mail attachment from a URL. | ||
| * | ||
| * @param string $url | ||
| * @return static |
Contributor
There was a problem hiding this comment.
You may add @throws here:
Suggested change
| * @return static | |
| * @throws \InvalidArgumentException |
Contributor
|
You may want to add "Backport" to your PR title, so the intention is immediately clear |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricts
Attachment::fromUrl()to http and https URLs. This keeps URL attachments aligned with their intended remote URL use case while rejecting unsupported schemes.