[13.x] Add support for after_commit for Cloud queue metrics#60078
Merged
taylorotwell merged 1 commit intoMay 12, 2026
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
timacdonald
commented
May 12, 2026
| $result = $this->queue->pushRaw(...func_get_args()); | ||
|
|
||
| $this->afterJobPushed($queue); | ||
| $this->finishQueueingJob($queue); |
Member
Author
There was a problem hiding this comment.
SqsQueue::pushRaw does not fire events and does not support after_commit, so we handle it here manually.
timacdonald
changed the title
after_commit for Cloud queue metrics.after_commit for Cloud queue metrics
Contributor
|
@timacdonald for my own understanding: why didn't you use a standardized format like statsd? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.