Skip to content

[13.x] Add unicode modifier to SeeInHtml normalize whitespace regex#60090

Merged
taylorotwell merged 1 commit into
laravel:13.xfrom
mosabbirrakib:see-in-html-unicode-modifier
May 13, 2026
Merged

[13.x] Add unicode modifier to SeeInHtml normalize whitespace regex#60090
taylorotwell merged 1 commit into
laravel:13.xfrom
mosabbirrakib:see-in-html-unicode-modifier

Conversation

@mosabbirrakib
Copy link
Copy Markdown
Contributor

SeeInHtml::normalize() is used by assertSee()-family assertions. The method explicitly decodes with 'UTF-8' on the line above, but the trailing preg_replace('/\\s+/', ' ', $value) doesn't have the /u flag — so HTML containing Unicode whitespace (non-breaking space, ideographic space, etc.) gets left in place instead of collapsed, causing assertSee() matches to silently fail. Same shape as #60056.

@taylorotwell taylorotwell merged commit 073a244 into laravel:13.x May 13, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants