[13.x] Allow passing scheduled Event in callbacks#60144
Merged
taylorotwell merged 3 commits intoMay 16, 2026
Conversation
Contributor
Author
|
Looks like test failure should be resolved by #60143 |
Event in callbacksEvent in callbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be a lovely pairing with #60133.
Background
Our team realized this week that some of our critical scheduled commands were dying on the vine due to OOM. It would be helpful to have standardized logs write
"Command {$event->command} started|completed|failed"in before and after hooks. Given that we have so many scheduled commands, it's a bit tedious to write the callbacks for all of them. Also... we have to remember to do it going forward 🫠What this does
Allows userland to typehint a callback with
Event $eventas a parameter, and pass$thisto it.Example