[13.x] Consistent test OS attributes#60162
Merged
taylorotwell merged 3 commits intoMay 18, 2026
Merged
Conversation
This was referenced May 18, 2026
jnoordsij
force-pushed
the
consistent-test-os-attributes
branch
from
5ecddf0 to
4a41a11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
RequiresOperatingSystemFamilyattribute is replaced withRequiresOperatingSystem, as the former will do exact string matching, with the latter doing a regex match. Given that this was used with the regex argumentLinux|Darwin, some tests were effectively always skipped.Linux|Darwinas argument, rather thanLinux|DAR. The latter likely works fine, as I suspect a case-insensitive regex match is done, but looks somewhat confusing and inconsistent. Darwin is correct per https://www.php.net/manual/en/reserved.constants.php#constant.php-os-family.After applying the fixes, the
SerializableClosureV1CacheRouteTestwas shown to not properly clean up, hence aparent::tearDownwas added.