[13.x] Add initial value type to return of reduce and reduceWithKeys#60178
Merged
Conversation
96df48f to
d25fd2d
Compare
reduce and reduceWithKeys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On empty collections, the
reduceandreduceWithKeysmethods will simply return the initial value:Hence this should be part of the return typehint.
In real-world scenarios, this may appear when one does something like
$collection->filter(<function where nothing passes>)->reduce(...)or$model->emptyRelation->reduce(...).Note that the
Enumerableinterface already (correctly) prescribes this:framework/src/Illuminate/Collections/Enumerable.php
Lines 882 to 892 in fa071b5