Skip to content

[13.x] Fix incorrect type hint in EncodedHtmlString::convert() docblock#60186

Merged
taylorotwell merged 1 commit into
laravel:13.xfrom
rpsohag:fix/encoded-html-string-docblock-type
May 19, 2026
Merged

[13.x] Fix incorrect type hint in EncodedHtmlString::convert() docblock#60186
taylorotwell merged 1 commit into
laravel:13.xfrom
rpsohag:fix/encoded-html-string-docblock-type

Conversation

@rpsohag
Copy link
Copy Markdown
Contributor

@rpsohag rpsohag commented May 19, 2026

Summary

Fixed a type mismatch in the EncodedHtmlString::convert() method's docblock.

Problem

The docblock annotated $withQuote as int but the actual parameter is bool $withQuote = true.

Solution

Changed the docblock annotation from @param int $withQuote to @param bool $withQuote.

Impact

  • No behavior changes
  • Documentation now matches implementation
  • Improves static analysis accuracy

@taylorotwell taylorotwell merged commit ea8c5c5 into laravel:13.x May 19, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants