Skip to content

[12.x] Fix FIFO queue name normalization in Cloud managed queues#60316

Merged
taylorotwell merged 1 commit into
laravel:12.xfrom
kieranbrown:fix-cloud-fifo-normalize-queue-12x
May 29, 2026
Merged

[12.x] Fix FIFO queue name normalization in Cloud managed queues#60316
taylorotwell merged 1 commit into
laravel:12.xfrom
kieranbrown:fix-cloud-fifo-normalize-queue-12x

Conversation

@kieranbrown
Copy link
Copy Markdown
Member

Foundation\Cloud\Queue::normalizeQueue() stripped the environment suffix with chopEnd($suffix), but for FIFO queues the suffix sits before the .fifo terminal (e.g. orders-{uuid}.fifo), so the chop was a no-op and Cloud queue events reported orders-{uuid}.fifo instead of orders.fifo — leaking the per-environment UUID and breaking per-queue grouping/metrics.

This makes normalizeQueue() FIFO-aware, mirroring SqsQueue::suffixQueue() in reverse. Standard queues are unaffected. Added a regression test.

Backport of #60315.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@taylorotwell taylorotwell merged commit e854b8c into laravel:12.x May 29, 2026
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants