[13.x] Fix Illuminate\Http\Response compatibility against Symfony 8.1#60318
Merged
Conversation
crynobone
force-pushed
the
13/symfony-80100
branch
3 times, most recently
from
19fc790 to
6acab91
Compare
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
force-pushed
the
13/symfony-80100
branch
from
6acab91 to
f633f34
Compare
Contributor
Member
Author
|
There's multiple changes that is outside the scope of the main issue, which this PR only focuses on avoiding deprecation. |
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
GrahamCampbell
approved these changes
May 29, 2026
Collaborator
GrahamCampbell
left a comment
GrahamCampbell
left a comment
There was a problem hiding this comment.
This looks like a much better approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids
Symfony\Component\HttpFoundation\Responsefrom throwing a deprecation when we set$headersproperty value in the constructor.Alternative to #60303 and avoid making public API changes in a patch release. We can consider making the property type change for Laravel 14.