[13.x] Add payload to InspectedJob#60326
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@ziadoz Good question for all of the inspection methods tbh, but this follows how it is already, I'd imagine there's a good pr for that tho 😉 - will poke it when I get time |
This comment was marked as outdated.
This comment was marked as outdated.
|
@ziadoz Encryption only happens on the command ie job via ie It could be worth looking at separately, if you wanted to tap into the command via the inspect stuff but not sure if anyone would really want to tap into the command or at least I dont have a use case for it yet :D |
If you use
Queue::createPayloadUsingwe may include additional payload information, but this isn't exposed via any of the queue inspection methods. (Thanks for pointing me at this method Taylor lol)This PR adds payload to the
InspectedJobso we can access it if we have any custom payload information.I considered a static buildUsing callback on InspectedJob to allow swapping the class entirely, but felt like exposing the payload was simpler? Open to your opinion tho cause I wasnt sure what you'd prefer / maybe a better way?
I moved about the vars cause createdAt seemed odd not being last, I guess a slight b/c but dont think anyone is using it in that way
I figured you can already see the payload in the DB etc, so no harm seeing it via the inspection methods, and also useful for debugging
Test included