Respect the encoding in Str::mask() when building the end of the string#60646
Merged
Conversation
Str::mask() accepts an $encoding argument and passes it to every mb_ call except the one that builds the portion of the string after the masked segment. That last mb_substr() used mb_substr()'s default encoding, so when a non UTF-8 encoding was passed the tail was sliced at the wrong character offsets and any multibyte characters after the mask got corrupted. For example, masking an ISO-8859-1 string turned "García" into "Garc?a". Passing $encoding to that mb_substr() call fixes it. Added assertions that mask an ISO-8859-1 string using both a positive and a negative index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Str::mask() accepts an $encoding argument and passes it to every mb_ call except the one that builds the portion of the string after the masked segment. That last mb_substr() used mb_substr()'s default encoding, so when a non UTF-8 encoding was passed the tail was sliced at the wrong character offsets and any multibyte characters after the mask got corrupted.
For example, masking an ISO-8859-1 string turned "García" into "Garc?a". Passing $encoding to that mb_substr() call fixes it. Added assertions that mask an ISO-8859-1 string using both a positive and a negative index.