[5.0] Fix CLI Dependencies

[devonzara]

Automatically instantiate a Request object if it's required. (Useful when running from the CLI where it would not already be instantiated.)

ServiceProviders using objects (eg. URLGenerator) which depend on a Request object were squaking due to receiving NULL instead of a Request object.

See here.

[crynobone]

Don't think it going to be enough, mainly because what is there to capture when you're inside a console? It need something similar to how request is resolved in 4.2 (and below).

[GrahamCampbell]

Also, you'd need to import this instead of using the fqcn.

[devonzara]

@crynobone The only time Request is not instantiated is when you're inside a console, therefore runningInConsole() would only be redundant.

@GrahamCampbell True, will remove the fqcn...

[crynobone]

Check 4.2 code.

[devonzara]

I have, it's irrelevant to your point as it used to load every time the application was loaded.

See here. The constructor used to instantiate the Request object immediately.

[crynobone]

See

    /**
     * Set the application request for the console environment.
     *
     * @return void
     */
    public function setRequestForConsoleEnvironment()
    {
        $url = $this['config']->get('app.url', 'http://localhost');

        $parameters = array($url, 'GET', array(), array(), array(), $_SERVER);

        $this->refreshRequest(static::onRequest('create', $parameters));
    }

Now, compare that with Request::capture().

As an example, how would capture() know your root URL?

[crynobone]

#6216 using bootstrap approach specifically for console kernel.