Allow setting Last-Modified header for file downloads #6619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Docblock need to be updated as well. |
Contributor
Author
|
@lucasmichot I just updated the DocBlocks for this change. I do not see that this method or most methods within this class have tests. Shall we hold off from merging until all of it has tests? |
Collaborator
|
Please send this to 5.0. This will be a pain to merge into 5.0 if sent to 4.2. |
Collaborator
|
@elliotfehr The class you're after in 5.0 is: https://github.com/laravel/framework/blob/master/src/Illuminate/Routing/ResponseFactory.php. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Response Facade does not allow configuring the autoEtag or autoLastModified parameters of a Symfony BinaryFileResponse. This simply accepts them as parameters and passes them to the Symfony class.