Skip to content

Allow setting Last-Modified header for file downloads #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elliotfehr wants to merge 2 commits into from
Closed

Allow setting Last-Modified header for file downloads #6619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa51bf0
allow setting Last-Modified header for file downloads
elliotfehr Dec 11, 2014
bef9fb5
updated Response download DocBlocks
elliotfehr Dec 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Illuminate/Support/Facades/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,13 @@ public static function stream($callback, $status = 200, array $headers = array()
* @param string $name
* @param array $headers
* @param null|string $disposition
* @param boolean $autoEtag
* @param boolean $autoLastModified
* @return \Symfony\Component\HttpFoundation\BinaryFileResponse
*/
public static function download($file, $name = null, array $headers = array(), $disposition = 'attachment')
public static function download($file, $name = null, array $headers = array(), $disposition = 'attachment', $autoEtag = false, $autoLastModified = true)
{
$response = new BinaryFileResponse($file, 200, $headers, true, $disposition);
$response = new BinaryFileResponse($file, 200, $headers, true, $disposition, $autoEtag, $autoLastModified);

if ( ! is_null($name))
{
Expand Down