[5.0] Do not call terminate method if handle method not called in StartSession middleware #7058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
missing fullstop and the description is rubbish
GrahamCampbell
changed the title
taylorotwell
added a commit
that referenced
this pull request
Jan 21, 2015
[5.0] Do not call terminate method if handle method not called in StartSession middleware
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting fatal error for application maintenance mode
ErrorException: Undefined index: _sf2_meta at /var/www/vendor/laravel/framework/src/Illuminate/Session/Store.php:280
If application in maintenance mode
Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode throw new HttpException(503);
and StartSession::handle method not called, but at the end of the request Laravel call terminate function in StartSession middleware to save session data and that why getting error "Undefined index: _sf2_meta at "
My change is checking if handle method not called, than not saving session data