Fixing relation queries to ignore the parent scope in order to avoid inf... #7066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…infinte loop on whereHas in global scope
Collaborator
|
Please fix on 4.2 and update the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered an issue when using whereHas inside a globalScope. When the global scope runs on the parent it calls whereHas which gets the related object which then gets the parents query object and runs the scope again. This results in a loop. Fixing this involves getting a scopeless query object from the parent when adding the relation in the whereHas. The global scope will still be applied to the parent object in its own right, just not apart of the relation building mechanism.