[5.0] Override defaults for artisan serve #7077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my work I must rely only with PHP built-in server in my develop machine to comply with IT policies, I can't use Apache or Vagrant. While working with multiple projects at time, I found boring typing over and over a different host/port (`php artisan serve --host xpto --port 8088`), so override `php artisan serve` defaults into a `.env` file sounded a good idea for me. I don't know if this is the best approach, maybe extract to a config file.
Collaborator
|
This adds coupling between the command and the environment system. This is not allowed. If we were to do this, we should inject the defaults into the command instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my work I must rely only with PHP built-in server in my develop machine to comply with IT policies, I can't use Apache, Ngnix, VMs or Vagrant.
While working with multiple projects at time, I found boring typing over and over a different host/port (
php artisan serve --host xpto --port 8088), so overridephp artisan servedefaults into a.envfile sounded a good idea for me.I don't know if this is the best approach, maybe extract this to a config file.