[5.0] Use model@hydrate in builder@getModels

[JosephSilber]

Use the model's hydrate method in the builder's getModels method, since they both do essentially the same thing.

This also simplifies the hydrate and hydrateRaw methods on the Model class.

[taylorotwell]

Conflicts?

[JosephSilber]

@taylorotwell rebased.

[JosephSilber]

@taylorotwell rebased again.

[JosephSilber]

Sigh... rebased again.

@taylorotwell Third time's a charm?

[GrahamCampbell]

string|null

[JosephSilber]

@GrahamCampbell It's not like that throughout the codebase, but... heck if that makes you happy :)

[GrahamCampbell]

It's not like that throughout the codebase

Yeh, I know. There's no point wasting time enforcing it everywhere, as with the short array syntax. We're just making sure new code is correct. Changing all the existing code is a total waste of time.

[JosephSilber]

Changing all the existing code is a total waste of time.

Wow! Who are you, and what have you done to @GrahamCampbell ?

[GrahamCampbell]

Lol. I just can't see the real benefit to going through ensuring all old docblocks have a |null in them where they should have one. Time is precious, and should be used to it's maximum potential. :)

[GrahamCampbell]

👍

[GrahamCampbell]

@JosephSilber Yeh, please do resend this to 5.0. :)