SES transport throws exception if sender not provided#9255
Merged
taylorotwell merged 2 commits intolaravel:5.1from Jun 13, 2015
Merged
SES transport throws exception if sender not provided#9255taylorotwell merged 2 commits intolaravel:5.1from
taylorotwell merged 2 commits intolaravel:5.1from
Conversation
Most users following the docs will send mail specifying $mail->from('me@example.com').
When using the SES transport this with throw 'key() expects parameter 1 to be array, null given' as sender is not specified
This patch will check if sender is null and replace it with the 'from' variable
Collaborator
There was a problem hiding this comment.
This doesn't look right. Just do: $message->getSender() ?: $message->getFrom()
as per @GrahamCampbell’s recommendation
taylorotwell
added a commit
that referenced
this pull request
Jun 13, 2015
SES transport throws exception if sender not provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most users following the docs will send mail specifying $mail->from('me@example.com').
When using the SES transport this will throw 'key() expects parameter 1 to be array, null given' as sender is not specified
This patch will check if sender is null and replace it with the 'from' variable