Fix for directories with spaces in current working directory path #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

taylorotwell merged 1 commit into laravel:master from evanbarter:master

Sep 8, 2020

Contributor

evanbarter commented Sep 8, 2020

Had a fresh install blow up today 😅 This PR:

Wraps $directory passed to (non-Windows) shell commands in quotes
Returns the process exit code so the test can catch a similar issue in the future
Applies the same quote wrapping to the test clean up shell command


          Fix for directories with spaces

ecdaaa5

taylorotwell merged commit ef8e322 into laravel:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet