Skip to content

Fix for directories with spaces in current working directory path #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Fix for directories with spaces in current working directory path #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/NewCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
if (PHP_OS_FAMILY == 'Windows') {
array_unshift($commands, "rd /s /q \"$directory\"");
} else {
array_unshift($commands, "rm -rf $directory");
array_unshift($commands, "rm -rf \"$directory\"");
}
}

if (PHP_OS_FAMILY != 'Windows') {
$commands[] = "chmod 644 $directory/artisan";
$commands[] = "chmod 644 \"$directory/artisan\"";
}

if ($this->runCommands($commands, $input, $output)->isSuccessful()) {
if (($process = $this->runCommands($commands, $input, $output))->isSuccessful()) {
if ($name && $name !== '.') {
$this->replaceInFile(
'APP_URL=http://localhost',
Expand All @@ -114,7 +114,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
$output->writeln(PHP_EOL.'<comment>Application ready! Build something amazing.</comment>');
}

return 0;
return $process->getExitCode();
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/NewCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function test_it_can_scaffold_a_new_laravel_app()
if (PHP_OS_FAMILY == 'Windows') {
exec("rd /s /q \"$scaffoldDirectory\"");
} else {
exec("rm -rf $scaffoldDirectory");
exec("rm -rf \"$scaffoldDirectory\"");
}
}

Expand Down