Skip to content

Conversation

@claudiodekker
Copy link
Contributor

@claudiodekker claudiodekker commented Jan 6, 2021

Jetstream 2.x no longer ships with the jetstream-js helper out of the box, preferring Inertia's first-party form helper instead. Since the guide/page already suggests reading the inertia.js documentation entirely, removing this section is sufficient.

Inertia 2.x no longer ships with the `jetstream-js` helper out of the box, preferring Inertia's first-party form helper instea, which is already documented on inertiajs.com
@reinink
Copy link

reinink commented Jan 6, 2021

Yeah, we'll definitely need to make a change here, as some APIs have changed entirely. For example, these two form options no longer exist:

bag: 'updateProfileInformation',
resetOnSuccess: true,

Looking at this change, it feels like we're removing a lot. And yet, all the form helper behaviour is now well documented on the Inertia website, here.

My only question would be, do we need to document the following Jetstream components, or can they just be something folks discover for themselves?

<jet-input-error >
<jet-action-message>
<jet-button>

@claudiodekker
Copy link
Contributor Author

claudiodekker commented Jan 6, 2021

Yeah, totally.. I thought over this a bit, and concluded that I'd rather delete it than add 'filler text' just to keep these components described for a couple of reasons:

  • I'm bad at coming up with filler text, and even if I manage to write something up, it would cause the page to not read in a 'single voice' like it does now.
  • There's a lot of other jet-components that aren't documented, and to understand those you already need at least a basic understanding of Vue.js. If you can understand those, you can also understand these.
  • Near the top of the page, it mentions this:

    When using the Inertia stack, Jetstream has some unique features that you should be aware of. We will discuss each of these features below.

@taylorotwell taylorotwell merged commit 48e92d9 into laravel:master Jan 6, 2021
@claudiodekker claudiodekker deleted the patch-1 branch January 6, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants