Use dynamic foreign key in cancelTeamInvitation#1590
Merged
taylorotwell merged 1 commit intolaravel:5.xfrom Dec 12, 2025
Merged
Use dynamic foreign key in cancelTeamInvitation#1590taylorotwell merged 1 commit intolaravel:5.xfrom
cancelTeamInvitation#1590taylorotwell merged 1 commit intolaravel:5.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1587,
TeamMemberManager::cancelTeamInvitation()hasteam_idhardcoded as the foreign key. This causes issues when customizing theTeamInvitationmodel to use different naming conventions (e.g.,company_id).I've replaced the hardcoded string with a dynamic lookup that resolves the key name directly from the model's relationship.