Add RedirectResponse return type to Logout action #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good 👍 |
Member
|
This method never actually returns a redirector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the correct return type declaration to the Logout action's
__invoke()method. The method needs a union type ofRedirectResponse|Redirectorto properly type-hint the return value of theredirect()helper function.I found that using only
RedirectResponseor onlyRedirectoras the return type wasn't sufficient to satisfy both tests and static analysis. The Laravelredirect()helper can return either type depending on the context. This union type solution ensures correct type checking while maintaining compatibility with Laravel's actual behavior.