-
Notifications
You must be signed in to change notification settings - Fork 56
Add Support For Resource Templates #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add meta and security scheme to tools * Fix phpstan definition * WIP 🚧 * WIP * Update the meta $property addition * Introduce `ResponseFactory` for handling responses with result-level metadata. * Replace `UnexpectedValueException` with `InvalidArgumentException` in `ResponseFactory` and improve type validation logic. * Formatting * Fix test and change the API * Refactor * Refactor * Update method signatures * Update Test * Improve testing --------- Co-authored-by: zacksmash <zachary.warren@me.com> # Conflicts: # tests/Unit/Methods/ReadResourceTest.php
* Remove non-spec fields from resource content responses * Update the minimum code coverage threshold to 91.7%
# Conflicts: # tests/Unit/Methods/ReadResourceTest.php
# Conflicts: # src/Server/Resource.php # tests/Unit/Methods/CallToolTest.php # tests/Unit/Methods/ListResourcesTest.php
joetannenbaum
requested changes
Nov 26, 2025
Collaborator
joetannenbaum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor changes, thanks Pushpak.
Member
|
Renamed interface to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #69
This PR introduces support for ResourceTemplate using an interface based approach. The earlier implementation required extending a dedicated ResourceTemplate class, which added extra structure that was not really necessary. With this update, URI template support becomes an optional capability that any resource can opt into by implementing a small interface.
Usage
URI Template
Why Simplified
The MCP spec references RFC 6570 for URI template behavior, but full RFC support is more than what MCP resources typically need. This intentionally implements a simpler subset. The approach mirrors what the official PHP MCP SDK docs here, and we followed the same interpretation.
Supported
{variable}{var1}/{var2}Not Supported
{+var}{#var}{.var}{/var}{?q,limit}{&page}{var*}Important
Variables cannot span across multiple path segments.