Skip to content

Conversation

@barryvdh
Copy link
Contributor

If the process exits, throw an error so it's more clear.
In my case it says this, but not sure if that's just me. At least for now show that it fails.

  INFO  Reloading workers...

   Symfony\Component\Process\Exception\ProcessFailedException 

  The command "'./rr' 'reset'" failed.

Exit Code: 1(General error)

Working directory: /home/barry/www/octane

Output:
================


Error Output:
================
rpc service disabled

@barryvdh
Copy link
Contributor Author

Maybe the reloadServer should return true/false on success/error, or always throw an exception when fails (so Swoole also)?
If this is part of a deployment script, you would perhaps want to abort when reload fails.

@taylorotwell taylorotwell merged commit ca294c4 into laravel:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants