Skip to content

Conversation

@mihaliak
Copy link
Contributor

@mihaliak mihaliak commented Apr 21, 2021

Hi,

we are getting errors in calculateElapsedTime method since it is not removing string before multiply.

ErrorException 

  A non-numeric value encountered

  at vendor/laravel/octane/src/Commands/StartRoadRunnerCommand.php:209
    205▕         if (Str::endsWith($elapsed, 'µs')) {
    206▕             return $elapsed * 0.001;
    207▕         }
    208▕ 
  ➜ 209▕         return $elapsed * 1000;
    210▕     }
    211▕ 
    212▕     /**
    213▕      * Stop the server.

This PR also fixes return type and force input string value to be float.

@taylorotwell taylorotwell merged commit 7e55e9b into laravel:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants