Skip to content

PHP 8.3 #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2023
Merged

PHP 8.3 #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a251d30
PHP 8.3
driesvints Sep 21, 2023
0a413c1
Fix code styling
driesvints Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.1, 8.2]
php: [8.1, 8.2, 8.3]
laravel: [10]
driver: [swoole, openswoole]

Expand Down
4 changes: 2 additions & 2 deletions src/Commands/StartRoadRunnerCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
class StartRoadRunnerCommand extends Command implements SignalableCommandInterface
{
use Concerns\InstallsRoadRunnerDependencies,
Concerns\InteractsWithServers,
Concerns\InteractsWithEnvironmentVariables;
Concerns\InteractsWithEnvironmentVariables,
Concerns\InteractsWithServers;

/**
* The command's signature.
Expand Down
2 changes: 1 addition & 1 deletion src/Commands/StartSwooleCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

class StartSwooleCommand extends Command implements SignalableCommandInterface
{
use Concerns\InteractsWithServers, Concerns\InteractsWithEnvironmentVariables;
use Concerns\InteractsWithEnvironmentVariables, Concerns\InteractsWithServers;

/**
* The command's signature.
Expand Down
2 changes: 0 additions & 2 deletions src/RoadRunner/Concerns/FindsRoadRunnerBinary.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ trait FindsRoadRunnerBinary
{
/**
* Find the RoadRunner binary used by the application.
*
* @return string
*/
protected function findRoadRunnerBinary(): ?string
{
Expand Down
2 changes: 0 additions & 2 deletions src/SymfonyProcessFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ class SymfonyProcessFactory
/**
* Create a new Symfony process instance.
*
* @param string $cwd
* @param array $env
* @param mixed|null $input
* @return \Symfony\Component\Process\Process
*/
Expand Down
4 changes: 0 additions & 4 deletions src/Worker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ public function boot(array $initialInstances = []): void

/**
* Handle an incoming request and send the response to the client.
*
* @param \Laravel\Octane\RequestContext $context
*/
public function handle(Request $request, RequestContext $context): void
{
Expand Down Expand Up @@ -181,8 +179,6 @@ public function handleTick(): void

/**
* Handle an uncaught exception from the worker.
*
* @param \Laravel\Octane\RequestContext $context
*/
protected function handleWorkerError(
Throwable $e,
Expand Down