Skip to content

Fix swoole host only configurable via --host parameter + incorrect default port #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Fix swoole host only configurable via --host parameter + incorrect default port #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceceef5
remove default values for --host
xorinzor Oct 15, 2023
63f7d66
fix incorrect default port
xorinzor Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/createSwooleServer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

$server = new Swoole\Http\Server(
$host,
$serverState['port'] ?? 8080,
$serverState['port'] ?? 8000,
$config['swoole']['mode'] ?? SWOOLE_PROCESS,
($config['swoole']['ssl'] ?? false)
? $sock | SWOOLE_SSL
Expand Down
2 changes: 1 addition & 1 deletion src/Commands/StartCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class StartCommand extends Command implements SignalableCommandInterface
*/
public $signature = 'octane:start
{--server= : The server that should be used to serve the application}
{--host=127.0.0.1 : The IP address the server should bind to}
{--host= : The IP address the server should bind to}
{--port= : The port the server should be available on [default: "8000"]}
{--rpc-host= : The RPC IP address the server should bind to}
{--rpc-port= : The RPC port the server should be available on}
Expand Down
2 changes: 1 addition & 1 deletion src/Commands/StartRoadRunnerCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class StartRoadRunnerCommand extends Command implements SignalableCommandInterfa
* @var string
*/
public $signature = 'octane:roadrunner
{--host=127.0.0.1 : The IP address the server should bind to}
{--host= : The IP address the server should bind to}
{--port= : The port the server should be available on}
{--rpc-host= : The RPC IP address the server should bind to}
{--rpc-port= : The RPC port the server should be available on}
Expand Down
2 changes: 1 addition & 1 deletion src/Commands/StartSwooleCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class StartSwooleCommand extends Command implements SignalableCommandInterface
* @var string
*/
public $signature = 'octane:swoole
{--host=127.0.0.1 : The IP address the server should bind to}
{--host= : The IP address the server should bind to}
{--port= : The port the server should be available on}
{--workers=auto : The number of workers that should be available to handle requests}
{--task-workers=auto : The number of task workers that should be available to handle tasks}
Expand Down