Skip to content

Cache improvements #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 11, 2023
Merged

Cache improvements #25

merged 7 commits into from
Oct 11, 2023

Conversation

@timacdonald
Copy link
Member

@timacdonald timacdonald commented Oct 6, 2023 •
edited by jessarcher
Loading

  • Cache keys are now normalised before they enter the database, removing the need to do any expensive regex matching at read time.
  • Cache table is now indexed to optimize reads.
  • Cache keys are always shown by most interactions (hits + misses) and limited to 100 results.

Additionally, the date boundaries for all cards has been fixed.

@timacdonald timacdonald changed the title [WIP] Cache improvements Cache improvements Oct 6, 2023
timacdonald
timacdonald commented Oct 9, 2023
View reviewed changes
timacdonald
timacdonald commented Oct 9, 2023
View reviewed changes
@timacdonald timacdonald marked this pull request as ready for review October 9, 2023 03:59
@timacdonald timacdonald requested a review from jessarcher October 9, 2023 04:00
timacdonald
timacdonald commented Oct 9, 2023
View reviewed changes
@taylorotwell taylorotwell marked this pull request as draft October 9, 2023 14:31
@taylorotwell
Copy link
Member

taylorotwell commented Oct 9, 2023

Drafting until @jessarcher reviews

jessarcher
jessarcher reviewed Oct 10, 2023
View reviewed changes
@jessarcher jessarcher marked this pull request as ready for review October 11, 2023 04:14
@jessarcher jessarcher merged commit 413efa5 into master Oct 11, 2023
@jessarcher jessarcher deleted the cache branch October 11, 2023 04:17
@swaty007 swaty007 mentioned this pull request Feb 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessarcher jessarcher jessarcher left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timacdonald @taylorotwell @jessarcher