Respect $hidden, $visible, and $appends on model components#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaces the three Eloquent serialization-control properties on the Model component and adds a visibleProperties() helper that applies them: $visible acts as a whitelist when set, otherwise $hidden filters the keys out. Operates over merged attributes + relations since Eloquent's $hidden/$visible apply to relationships as well as columns.
Values are read via reflection on the model's default properties because a docblock @var (which the Laravel skeleton ships on $hidden) causes Surveyor to keep the typed array shape and discard the literal items. The existing $with extraction is moved to the same approach so it isn't silently broken by the same docblock pattern.
Closes laravel/wayfinder#135