Skip to content

Conversation

@drbyte
Copy link
Contributor

@drbyte drbyte commented Nov 29, 2020

Improvements to "valet use" command

  • valet use can now display the currently-linked PHP version, for quick inspection
  • properly detects if the requested version is already installed, and skips re-installing/re-starting/re-configuring
    • allows --force to re-configure anyway
  • smarter treatment of short 'php' name when it's aliased to another specific installed version

All in all, should be faster and a little more user-friendly.

- properly detects if the requested version is already installed, and skips re-installing/re-starting/re-configuring
- allows --force to re-configure anyway
- smarter treatment of 'php' when it's aliased to another specific installed version
@drbyte
Copy link
Contributor Author

drbyte commented Nov 29, 2020

Merge note: In my testing, even though tests are touched, merging 1004, 1006, 1007 in order first before this one results in no merge conflicts.

@mattstauffer
Copy link
Collaborator

I read it, but I'm going to have to take your word that it's good :) Thanks for your hard work on this!!

@mattstauffer mattstauffer merged commit 04d42b3 into laravel:master Nov 30, 2020
@drbyte drbyte deleted the valet-use-improvements branch November 30, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants