Allow valet share to support multiple domains from same app #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows passing a specific domain name to `valet share` in order to have the app be served for that domain. Now how it works is this: - (NEW) if a domain name is passed, it checks whether it matches a link (which would be required for multiple domains served by same app project), and uses that - if a domain name is NOT passed, it looks up any links for current directory, and uses the first found link - else falls back to current project foldername It also still allows passing through custom ngrok parameters if desired (ref: laravel#112), as either the 2nd parameter (no domain name passed) or (NEW) 3rd parameter Fixes laravel#537
Co-Authored-By: Matt Stauffer <mattstauffer@users.noreply.github.com>
Collaborator
|
🙌 |
|
Thanks a lot for this! |
|
Can't get this to work. Valet share always picks the first linked domain. |
Same |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows passing a specific domain name to
valet sharein order to have the app be served for that domain.Now how it works is this:
It also still allows passing through custom ngrok parameters if desired (ref: #112), as either the 2nd parameter (no domain name passed) or (NEW) 3rd parameter
Fixes #537