Skip to content

Apply fixes from StyleCI #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Apply fixes from StyleCI #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/Exceptions/CannotCreateUser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@

class CannotCreateUser extends Exception
{
public static function duplicateEmailAddress(string $emailAddress): CannotCreateUser
public static function duplicateEmailAddress(string $emailAddress): self
{
return new static("The email address [$emailAddress] already exists.");
}

public static function duplicateUsername(string $username): CannotCreateUser
public static function duplicateUsername(string $username): self
{
return new static("The username [$username] already exists.");
}
Expand Down
6 changes: 3 additions & 3 deletions app/User.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,17 +216,17 @@ public function countSolutions(): int
})->count();
}

public static function findByUsername(string $username): User
public static function findByUsername(string $username): self
{
return static::where('username', $username)->firstOrFail();
}

public static function findByEmailAddress(string $emailAddress): User
public static function findByEmailAddress(string $emailAddress): self
{
return static::where('email', $emailAddress)->firstOrFail();
}

public static function findByGithubId(string $githubId): User
public static function findByGithubId(string $githubId): self
{
return static::where('github_id', $githubId)->firstOrFail();
}
Expand Down