Skip to content

Format the article editor #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

Format the article editor #512

merged 1 commit into from
Apr 20, 2020

Conversation

@joedixon
Copy link
Contributor

@joedixon joedixon commented Apr 19, 2020 •
edited
Loading

This PR makes some subtle changes to inputs and styles:

  • Fields repopulate correctly when form validation fails
  • Choices select/multi-select field styled more consistently with the rest of the UI
  • Markdown editor increases in size as the user types

Screenshot 2020-04-19 at 16 04 13

Screenshot 2020-04-19 at 15 39 12

driesvints
driesvints reviewed Apr 19, 2020
View reviewed changes
@driesvints
Copy link
Member

driesvints commented Apr 20, 2020

@joedixon btw, can you always push new commits instead of amending? Makes it easier to review again.

@joedixon joedixon merged commit 537d5e8 into articles Apr 20, 2020
@joedixon joedixon deleted the editor branch April 20, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driesvints driesvints driesvints approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joedixon @driesvints