Skip to content

Conversation

@faissaloux
Copy link
Contributor

This PR fix nav links that was limited only on link text and not the whole tab

Before

before1
before2

After

after1
after2

@driesvints
Copy link
Member

Hmm I don't really see any issue here sorry

@driesvints driesvints closed this Sep 7, 2021
@faissaloux
Copy link
Contributor Author

You can't click on the tab to go to the link, you have to click exactly on text!!

@driesvints
Copy link
Member

Ah now I see it. Thanks, I'll check into this later.

@driesvints driesvints reopened this Sep 7, 2021
Copy link
Contributor

@joedixon joedixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addtion @faissaloux, thank you!

@joedixon joedixon merged commit 28e4c04 into laravelio:main Sep 20, 2021
@faissaloux faissaloux deleted the fix-nav-links branch September 20, 2021 12:36
@faissaloux
Copy link
Contributor Author

Happy to help 😄

@faissaloux faissaloux mentioned this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants