fix(docs): normalize board_tokens in +create response for mermaid/whiteboard content#10
Merged
SunPeiYang996 merged 1 commit intolarksuite:mainfrom Apr 8, 2026
Conversation
…teboard content +update already calls normalizeDocsUpdateResult to surface board_tokens when markdown contains mermaid/plantuml/whiteboard blocks. +create was missing the same call, so callers could not know how many whiteboards were created or retrieve their tokens. One-line fix: call normalizeDocsUpdateResult after CallMCPTool in DocsCreate.Execute.
|
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage ? 47.85%
=======================================
Files ? 280
Lines ? 22979
Branches ? 0
=======================================
Hits ? 10996
Misses ? 11001
Partials ? 982 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SunPeiYang996
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docs +updatecallsnormalizeDocsUpdateResultafter executing, which surfacesboard_tokensin the response when the markdown contains mermaid/plantuml/whiteboard blocks.docs +createis missing the same call.As a result, a caller who creates a document with mermaid diagrams via
+createcannot know how many whiteboards were created or retrieve their tokens — even though the exact same information is available from the underlying MCP response.Repro:
Fix
Call
normalizeDocsUpdateResultinDocsCreate.ExecuteafterCallMCPTool, identical to howDocsUpdate.Executedoes it. One-line change.Notes
normalizeDocsUpdateResult(and its helpersisWhiteboardCreateMarkdown,normalizeBoardTokens) live in the samedocpackage and are accessible without any export changes.normalizeDocsUpdateResultis a no-op in that case).