feat: get minutes keywords#1079
Conversation
Parse keywords from minutes artifacts API in vc +notes and document the field in lark-vc skill references. Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughThe PR extends the voice-to-notes feature to extract and return a ChangesKeywords artifact for voice-to-notes feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/vc/vc_notes_test.go`:
- Line 129: Add an assertion that the response JSON includes artifacts.keywords
with the expected values ["budget","roadmap"]; locate the test that loads the
fixture (around the existing artifact assertions in vc_notes_test.go) and after
parsing the response into the JSON object (e.g., respJSON, result, or similar
variable used in that test) add an assertion such as using
require.Equal/require.ElementsMatch to check respJSON["artifacts"]["keywords"]
equals []string{"budget","roadmap"} so the new parsing path is verified.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 899a0c57-ca19-446a-9b4f-f260011c5981
📒 Files selected for processing (4)
shortcuts/vc/vc_notes.goshortcuts/vc/vc_notes_test.goskills/lark-vc/SKILL.mdskills/lark-vc/references/lark-vc-notes.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@d43b1b8c075ca5bd5dc7cf4b174fe083c09b088c🧩 Skill updatenpx skills add larksuite/cli#feat/get_keywords_0520 -y -g |
zhangjun-bytedance
left a comment
There was a problem hiding this comment.
fixed
Parse keywords from minutes artifacts API in vc +notes and document the field in lark-vc skill references.
Summary
Changes
Test Plan
lark xxxcommand works as expectedRelated Issues
Summary by CodeRabbit
New Features
Documentation