Skip to content

feat: get minutes keywords#1079

Merged
zhangjun-bytedance merged 1 commit into
mainfrom
feat/get_keywords_0520
May 26, 2026
Merged

feat: get minutes keywords#1079
zhangjun-bytedance merged 1 commit into
mainfrom
feat/get_keywords_0520

Conversation

@zhangjun-bytedance
Copy link
Copy Markdown
Collaborator

@zhangjun-bytedance zhangjun-bytedance commented May 25, 2026

Parse keywords from minutes artifacts API in vc +notes and document the field in lark-vc skill references.

Summary

Changes

  • Change 1
  • Change 2

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark xxx command works as expected

Related Issues

  • None

Summary by CodeRabbit

  • New Features

    • Meeting minutes processing now automatically extracts and returns AI-recommended keywords derived from transcript content.
  • Documentation

    • Updated API schema documentation for the meeting minutes response to include the new keywords field.
    • Updated system resource architecture diagrams to reflect that meeting minutes now produce recommended keywords as an output artifact.

Review Change Stack

Parse keywords from minutes artifacts API in vc +notes and document
the field in lark-vc skill references.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

📝 Walkthrough

Walkthrough

The PR extends the voice-to-notes feature to extract and return a keywords artifact array from the minutes API. The implementation reads keywords from the API response, includes them in the result when non-empty, and updates test fixtures and documentation to reflect this new field.

Changes

Keywords artifact for voice-to-notes feature

Layer / File(s) Summary
Keywords extraction from API and test contract
shortcuts/vc/vc_notes.go, shortcuts/vc/vc_notes_test.go
fetchInlineArtifacts conditionally reads and includes the keywords array from the API response; test fixture is updated to mock keywords in the /minutes/{token}/artifacts response.
Resource relationship and schema documentation
skills/lark-vc/SKILL.md, skills/lark-vc/references/lark-vc-notes.md
Documentation diagrams and API schema reference are updated to show that minutes now produce keywords as an inline JSON artifact alongside other fields.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

domain/vc, size/M

Suggested reviewers

  • zhaoleibd
  • fangshuyu-768

Poem

🐇 Keywords now bloom from minutes bright,
A simple thread, yet shining light,
Extract, test, and document with care,
The notes now flourish, rich and fair!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete. While the Summary section briefly describes the feature, the Changes section contains only placeholder text ('Change 1', 'Change 2') rather than specific implementation details, and the Test Plan checklist items are unchecked. Replace placeholder text with actual changes made (e.g., 'Added keywords parsing in fetchInlineArtifacts', 'Updated test mocks', 'Documented keywords field in lark-vc references'). Indicate test status by checking completed items or providing verification details.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: get minutes keywords' is concise, clear, and accurately summarizes the main feature addition of parsing keywords from the minutes artifacts API.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/get_keywords_0520

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/vc PR touches the vc domain size/M Single-domain feat or fix with limited business impact labels May 25, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@shortcuts/vc/vc_notes_test.go`:
- Line 129: Add an assertion that the response JSON includes artifacts.keywords
with the expected values ["budget","roadmap"]; locate the test that loads the
fixture (around the existing artifact assertions in vc_notes_test.go) and after
parsing the response into the JSON object (e.g., respJSON, result, or similar
variable used in that test) add an assertion such as using
require.Equal/require.ElementsMatch to check respJSON["artifacts"]["keywords"]
equals []string{"budget","roadmap"} so the new parsing path is verified.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 899a0c57-ca19-446a-9b4f-f260011c5981

📥 Commits

Reviewing files that changed from the base of the PR and between ac06eaa and d43b1b8.

📒 Files selected for processing (4)
  • shortcuts/vc/vc_notes.go
  • shortcuts/vc/vc_notes_test.go
  • skills/lark-vc/SKILL.md
  • skills/lark-vc/references/lark-vc-notes.md

Comment thread shortcuts/vc/vc_notes_test.go
@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@d43b1b8c075ca5bd5dc7cf4b174fe083c09b088c

🧩 Skill update

npx skills add larksuite/cli#feat/get_keywords_0520 -y -g

Copy link
Copy Markdown
Collaborator Author

@zhangjun-bytedance zhangjun-bytedance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@zhangjun-bytedance zhangjun-bytedance merged commit 0bf590d into main May 26, 2026
39 of 41 checks passed
@zhangjun-bytedance zhangjun-bytedance deleted the feat/get_keywords_0520 branch May 26, 2026 10:42
@liangshuo-1 liangshuo-1 mentioned this pull request May 26, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/vc PR touches the vc domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants