Skip to content

fix(vc): correct --minute-token flag name in recording reference#1170

Merged
Ren1104 merged 1 commit into
mainfrom
refactor/vc-cleanup
May 29, 2026
Merged

fix(vc): correct --minute-token flag name in recording reference#1170
Ren1104 merged 1 commit into
mainfrom
refactor/vc-cleanup

Conversation

@Ren1104
Copy link
Copy Markdown
Collaborator

@Ren1104 Ren1104 commented May 29, 2026

Summary

Fix --minute-token (singular) → --minute-tokens (plural) in lark-vc-recording.md. The actual CLI flag defined in minutes_download.go is --minute-tokens, but the reference document had 3 occurrences using the wrong singular form.

Changes

  • skills/lark-vc/references/lark-vc-recording.md: lines 85, 118, 128

Test plan

  • grep -n 'minute-token' skills/lark-vc/references/lark-vc-recording.md — no singular --minute-token remains
  • Verified against shortcuts/minutes/minutes_download.go:48 — flag name is minute-tokens

Summary by CodeRabbit

  • Documentation
    • Updated the lark-cli minutes download command documentation to reflect the correct plural option format for minute tokens across Agent combination scenarios.

Review Change Stack

@Ren1104 Ren1104 added documentation Improvements or additions to documentation domain/vc PR touches the vc domain labels May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f1e5442f-0e62-46f8-9f8d-7da54a92c255

📥 Commits

Reviewing files that changed from the base of the PR and between 9306add and 641136a.

📒 Files selected for processing (1)
  • skills/lark-vc/references/lark-vc-recording.md
✅ Files skipped from review due to trivial changes (1)
  • skills/lark-vc/references/lark-vc-recording.md

📝 Walkthrough

Walkthrough

Documentation update correcting the lark-cli minutes +download command flag from --minute-token to --minute-tokens across three meeting recording download scenario examples in the recording reference guide.

Changes

Minutes Download Flag Corrections

Layer / File(s) Summary
Minutes download command flag corrections
skills/lark-vc/references/lark-vc-recording.md
Three meeting recording download scenarios updated to use the correct plural flag --minute-tokens instead of --minute-token in minutes +download command examples.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • larksuite/cli#591: Both PRs modify the minute-download guidance in skills/lark-vc/references/lark-vc-recording.md, correcting/standardizing minutes +download to use the proper --minute-tokens <minute_token>.
  • larksuite/cli#732: Both PRs update the documentation around minute token handling, including the --minute-tokens option naming in minute download flows.

Suggested reviewers

  • hugang-lark

Poem

🐰 Three little flags, now plural and bright,
--minute-tokens fixed, documentation's right!
From singular to many, the CLI commands sing,
Clean and correct—a simple, helpful thing! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: correcting the flag name from singular to plural in the recording reference documentation.
Description check ✅ Passed The description includes a clear summary of the fix, specific line numbers changed, and verification steps performed; all required template sections are addressed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/vc-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/L Large or sensitive change across domains or core paths label May 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.92%. Comparing base (a2cc5e1) to head (641136a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
+ Coverage   68.77%   68.92%   +0.14%     
==========================================
  Files         628      628              
  Lines       58670    58744      +74     
==========================================
+ Hits        40353    40487     +134     
+ Misses      15021    14951      -70     
- Partials     3296     3306      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@641136a0ae094f43400c9faf72838d6e3cdf2fee

🧩 Skill update

npx skills add larksuite/cli#refactor/vc-cleanup -y -g

@Ren1104 Ren1104 changed the title docs(vc): targeted skill quality improvements fix(vc): correct --minute-token flag name in recording reference May 29, 2026
@github-actions github-actions Bot added size/M Single-domain feat or fix with limited business impact and removed size/L Large or sensitive change across domains or core paths labels May 29, 2026
…ence

Fix 3 occurrences of --minute-token (singular) to --minute-tokens
(plural) in lark-vc-recording.md to match the actual CLI flag
definition in minutes_download.go.
@Ren1104 Ren1104 force-pushed the refactor/vc-cleanup branch from 214bdd7 to 641136a Compare May 29, 2026 08:12
@Ren1104 Ren1104 requested a review from liangshuo-1 May 29, 2026 08:13
@Ren1104 Ren1104 merged commit 1ba107d into main May 29, 2026
21 checks passed
@Ren1104 Ren1104 deleted the refactor/vc-cleanup branch May 29, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation domain/vc PR touches the vc domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants