Skip to content

docs(vc-agent): require explicit leave request#1260

Merged
zhicong666-bytedance merged 1 commit into
mainfrom
docs/vc-agent-explicit-leave-only
Jun 4, 2026
Merged

docs(vc-agent): require explicit leave request#1260
zhicong666-bytedance merged 1 commit into
mainfrom
docs/vc-agent-explicit-leave-only

Conversation

@zhicong666-bytedance
Copy link
Copy Markdown
Collaborator

@zhicong666-bytedance zhicong666-bytedance commented Jun 4, 2026

Summary

Update the lark-vc-agent skill docs so +meeting-leave is only used when the user explicitly asks the agent to exit, leave, or end participation. This avoids treating task completion, note retrieval, or sending follow-up messages as an implicit leave signal.

Changes

  • Clarify that +meeting-join uses a 9-digit meeting number, while +meeting-leave requires meeting_id.
  • Remove examples that present leave as the default final step after joining or completing a task.
  • Mark leave as an optional explicit-user-request action across the main skill and join/events/leave references.
  • Clarify that post-meeting recording and notes retrieval does not require leaving first.

Test Plan

  • git diff --check
  • bash scripts/check-doc-tokens.sh skills/lark-vc-agent
  • bash scripts/check-skill-wire-vocab.sh

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Clarified meeting workflow sequences: agent now reads in-progress events after joining, fetches notes/recordings after meeting end, and leaves only upon explicit user request.
    • Updated guidance on meeting ID usage and noted that leaving is reversible via re-joining.
    • Refined examples to reflect correct workflow order and explicit leave request handling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 13d9256a-5af4-4eff-a4df-8e98bc3639bb

📥 Commits

Reviewing files that changed from the base of the PR and between 7a0dbe0 and b2ed7af.

📒 Files selected for processing (4)
  • skills/lark-vc-agent/SKILL.md
  • skills/lark-vc-agent/references/lark-vc-agent-meeting-events.md
  • skills/lark-vc-agent/references/lark-vc-agent-meeting-join.md
  • skills/lark-vc-agent/references/lark-vc-agent-meeting-leave.md

📝 Walkthrough

Walkthrough

Documentation for the lark-vc-agent skill is updated to clarify meeting lifecycle semantics: +meeting-leave should be called only on explicit user requests, and recommended workflows are resequenced from immediate-leave patterns to event-polling and post-meeting-fetch patterns.

Changes

Meeting Leave Invocation Semantics

Layer / File(s) Summary
Meeting leave invocation conditions
skills/lark-vc-agent/references/lark-vc-agent-meeting-leave.md, skills/lark-vc-agent/references/lark-vc-agent-meeting-events.md
Core semantic shift establishes that +meeting-leave requires explicit user intent (exit/leave/end-participation) rather than automatic task completion; reference descriptions updated to match this conditional invocation pattern.
Post-join event polling flow in references
skills/lark-vc-agent/references/lark-vc-agent-meeting-join.md
Meeting-join reference scenarios restructured: scenario 1 replaces "join then leave" loop with "join then listen for events," and scenario 2 replaces early leave with query-recording steps to obtain minute_token.
Leave operation documentation and scenarios
skills/lark-vc-agent/references/lark-vc-agent-meeting-leave.md, skills/lark-vc-agent/SKILL.md
Meeting-leave documentation rewritten to clarify conditional invocation: agent combination scenarios show explicit-request-only patterns, and examples instruct users not to call leave when only post-meeting deliverables are needed.
Workflow examples and guidance tips
skills/lark-vc-agent/SKILL.md, skills/lark-vc-agent/references/lark-vc-agent-meeting-join.md, skills/lark-vc-agent/references/lark-vc-agent-meeting-leave.md
Skill documentation and reference tips updated to reflect new workflow sequencing: end-of-meeting workflow joins, reads events, optionally fetches notes, and defers leave until explicit user request; tips clarify meeting.id dependency and exit guidance paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~8 minutes

Possibly related PRs

  • larksuite/cli#824: Introduces the new VC agent meeting shortcuts (+meeting-join, +meeting-events, +meeting-leave) that this PR documents and clarifies usage patterns for.

Suggested labels

domain/vc, documentation, size/S

Suggested reviewers

  • hugang-lark

Poem

🐰 A rabbit hops through meetings newfound,
Join the call, then listen to sounds—
No hasty leave without a word,
Just notes and events, perfectly heard!
Hop, poll, and stay, till farewell is earned!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: requiring explicit user requests for +meeting-leave instead of treating task completion as an implicit leave signal.
Description check ✅ Passed The description follows the template with all required sections: Summary explains motivation clearly, Changes lists four main points, Test Plan includes verified checks, and Related Issues is documented.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/vc-agent-explicit-leave-only

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Jun 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.64%. Comparing base (8ce3879) to head (b2ed7af).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1260   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         666      666           
  Lines       64413    64413           
=======================================
  Hits        44861    44861           
  Misses      15943    15943           
  Partials     3609     3609           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@b2ed7af0047eeec3cdc41e8fb27d10749583053b

🧩 Skill update

npx skills add larksuite/cli#docs/vc-agent-explicit-leave-only -y -g

@zhicong666-bytedance zhicong666-bytedance merged commit 256df8c into main Jun 4, 2026
22 checks passed
@zhicong666-bytedance zhicong666-bytedance deleted the docs/vc-agent-explicit-leave-only branch June 4, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants