fix: expose completion state in my tasks output#1641
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesTask completion state in GetMyTasks
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/task/task_get_my_tasks_test.go`:
- Around line 113-167: Add a regression test for the pretty output path in
GetMyTasks, since the current TestGetMyTasks_IncludesCompletionStateInJSON only
verifies the JSON branch. Extend the task shortcut test coverage to run
GetMyTasks with the default pretty format and assert the new “Completed” and
“Completed At” lines are printed for both an open task and a completed task; use
the existing GetMyTasks shortcut and task task data setup to locate the behavior
change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 756d84f4-dfa1-44a3-867d-f2ffba8e038d
📒 Files selected for processing (4)
shortcuts/task/task_get_my_tasks.goshortcuts/task/task_get_my_tasks_test.gotests/cli_e2e/task/coverage.mdtests/cli_e2e/task/task_get_my_tasks_dryrun_test.go
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@6efa2446671ef5f8e32bd0aac96dfb4f560d92a3🧩 Skill updatenpx skills add ILUO/cli#codex/task-my-tasks-completed-status -y -g |
Summary
task +get-my-tasksnow exposes explicit completion state in task list output so agents can classify full result sets without relying on--completefiltering.Changes
completedboolean to each JSON item, derived fromcompleted_at.completed_atfor completed tasks and show completion state in pretty output.task +get-my-tasks.Test Plan
make unit-testlark-cli task +get-my-tasksflow works as expected viamake buildandgo test ./tests/cli_e2e/task -run TestTask_GetMyTasksDryRun -count=1go vet ./...gofmt -l .go mod tidywith nogo.mod/go.sumchangesgo run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --new-from-rev=origin/mainRelated Issues
Summary by CodeRabbit
New Features
completed) in JSON output and “Completed” in plain-text output.completed_at/ “Completed At”) formatted for readability.Bug Fixes
Tests