Skip to content

Fix/task get my tasks complete flag help#310

Merged
zero-my merged 2 commits intolarksuite:mainfrom
zero-my:fix/task-get-my-tasks-complete-flag-help
Apr 8, 2026
Merged

Fix/task get my tasks complete flag help#310
zero-my merged 2 commits intolarksuite:mainfrom
zero-my:fix/task-get-my-tasks-complete-flag-help

Conversation

@zero-my
Copy link
Copy Markdown
Collaborator

@zero-my zero-my commented Apr 8, 2026

Summary

Updated the help description of the --complete flag in the task +get-my-tasks shortcut to clarify its behavior for AI agents and users.

Changes

  • Modified shortcuts/task/task_get_my_tasks.go: Expanded the Desc of the complete flag to explicitly state that false queries incomplete tasks, and omitting the flag queries both completed and incomplete tasks.
  • Inherited documentation updates for the lark-task-get-my-tasks skill reference to match this behavior.

Test Plan

  • Unit tests pass
  • golangci-lint check passes
  • Manual local verification confirms the help output is correct

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Clarified the behavior of the --complete flag for filtering tasks in the get-my-tasks command, including scenarios when the flag is explicitly enabled, disabled, or not provided.
    • Updated example commands to demonstrate retrieving all tasks, incomplete tasks only, and paginated search results.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

Updated help text and documentation for the --complete flag in the get-my-tasks command to clarify filtering behavior: true queries completed tasks, false queries incomplete tasks, and omitting the flag queries both. No logic or control flow modifications.

Changes

Cohort / File(s) Summary
Command help text
shortcuts/task/task_get_my_tasks.go
Updated complete flag description to clarify the three filtering scenarios and their corresponding results.
Documentation examples
skills/lark-task/references/lark-task-get-my-tasks.md
Relabeled base example to "Get all my tasks," added explicit --complete=false example for incomplete tasks, and clarified the --complete parameter semantics.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

domain/task, size/M

Suggested reviewers

  • tengchengwei

Poem

🐰 A flag once cryptic, now shining bright,
Complete or not, we've set it right!
Task queries dance with clarity's gleam,
Documentation dreams fulfilled with this beam! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly relates to the main change—updating the help text for the --complete flag in the task get-my-tasks command to clarify its filtering behavior.
Description check ✅ Passed The description covers all required template sections: Summary explains the change clearly, Changes lists the modifications in detail, Test Plan confirms testing was performed, and Related Issues is addressed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added domain/task PR touches the task domain size/M Single-domain feat or fix with limited business impact labels Apr 8, 2026
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 8, 2026

Greptile Summary

This PR clarifies the three-state behavior of the --complete flag (true → completed, false → incomplete, omitted → both) in both the Go flag description and the skill reference markdown. The underlying logic was already correct; only documentation/help text is changed.

Confidence Score: 5/5

Safe to merge — only documentation and help-text changes; the sole finding is a minor typo/style issue.

All findings are P2 (wording/style). The logic and behavior are correct and unchanged. No functional risk.

No files require special attention.

Vulnerabilities

No security concerns identified. Changes are limited to help-text strings and documentation.

Important Files Changed

Filename Overview
shortcuts/task/task_get_my_tasks.go Updated --complete flag description to clarify three-state behavior; minor typo ("incompleted") and missing space after semicolon in new description text.
skills/lark-task/references/lark-task-get-my-tasks.md Added --complete=false example and corrected the bare-command comment from "incomplete tasks" to "all tasks"; documentation is accurate and consistent with the code logic.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[lark-cli task +get-my-tasks] --> B{--complete flag provided?}
    B -- "not provided" --> C[query both completed & incomplete tasks]
    B -- "true" --> D[query completed=true]
    B -- "false" --> E[query completed=false\nincomplete tasks only]
    C --> F[API GET /v2/tasks]
    D --> F
    E --> F
    F --> G[Client-side filter:\ncreated_at / due-start / due-end / query]
    G --> H[Output paginated results]
Loading

Reviews (1): Last reviewed commit: "fix: clarify complete flag description i..." | Re-trigger Greptile

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@shortcuts/task/task_get_my_tasks.go`:
- Line 32: The help text for the "complete" flag currently uses the nonstandard
phrase "incompleted tasks"; update the user-facing description in
shortcuts/task/task_get_my_tasks.go where the flag/arg named "complete" is
defined to replace "incompleted" with "incomplete" so the Desc reads: "if true,
query completed tasks; if false, query incomplete tasks; if not provided, both
completed and incomplete tasks are queried." Ensure you only change the wording
in the Desc string for the "complete" flag.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4f0b59ac-a4ef-4cf7-be47-e1d9eadbd537

📥 Commits

Reviewing files that changed from the base of the PR and between 12bb01a and 4f1c9b9.

📒 Files selected for processing (2)
  • shortcuts/task/task_get_my_tasks.go
  • skills/lark-task/references/lark-task-get-my-tasks.md

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@4f1c9b95bc434fca5ada757b91bc07dfceadce55

🧩 Skill update

npx skills add zero-my/cli#fix/task-get-my-tasks-complete-flag-help -y -g

@zero-my zero-my merged commit fe8da8d into larksuite:main Apr 8, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/task PR touches the task domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants