Fix/task get my tasks complete flag help#310
Conversation
📝 WalkthroughWalkthroughUpdated help text and documentation for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR clarifies the three-state behavior of the Confidence Score: 5/5Safe to merge — only documentation and help-text changes; the sole finding is a minor typo/style issue. All findings are P2 (wording/style). The logic and behavior are correct and unchanged. No functional risk. No files require special attention.
|
| Filename | Overview |
|---|---|
| shortcuts/task/task_get_my_tasks.go | Updated --complete flag description to clarify three-state behavior; minor typo ("incompleted") and missing space after semicolon in new description text. |
| skills/lark-task/references/lark-task-get-my-tasks.md | Added --complete=false example and corrected the bare-command comment from "incomplete tasks" to "all tasks"; documentation is accurate and consistent with the code logic. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[lark-cli task +get-my-tasks] --> B{--complete flag provided?}
B -- "not provided" --> C[query both completed & incomplete tasks]
B -- "true" --> D[query completed=true]
B -- "false" --> E[query completed=false\nincomplete tasks only]
C --> F[API GET /v2/tasks]
D --> F
E --> F
F --> G[Client-side filter:\ncreated_at / due-start / due-end / query]
G --> H[Output paginated results]
Reviews (1): Last reviewed commit: "fix: clarify complete flag description i..." | Re-trigger Greptile
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@shortcuts/task/task_get_my_tasks.go`:
- Line 32: The help text for the "complete" flag currently uses the nonstandard
phrase "incompleted tasks"; update the user-facing description in
shortcuts/task/task_get_my_tasks.go where the flag/arg named "complete" is
defined to replace "incompleted" with "incomplete" so the Desc reads: "if true,
query completed tasks; if false, query incomplete tasks; if not provided, both
completed and incomplete tasks are queried." Ensure you only change the wording
in the Desc string for the "complete" flag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4f0b59ac-a4ef-4cf7-be47-e1d9eadbd537
📒 Files selected for processing (2)
shortcuts/task/task_get_my_tasks.goskills/lark-task/references/lark-task-get-my-tasks.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@4f1c9b95bc434fca5ada757b91bc07dfceadce55🧩 Skill updatenpx skills add zero-my/cli#fix/task-get-my-tasks-complete-flag-help -y -g |
Summary
Updated the help description of the
--completeflag in thetask +get-my-tasksshortcut to clarify its behavior for AI agents and users.Changes
shortcuts/task/task_get_my_tasks.go: Expanded theDescof thecompleteflag to explicitly state thatfalsequeries incomplete tasks, and omitting the flag queries both completed and incomplete tasks.lark-task-get-my-tasksskill reference to match this behavior.Test Plan
golangci-lintcheck passesRelated Issues
Summary by CodeRabbit
--completeflag for filtering tasks in the get-my-tasks command, including scenarios when the flag is explicitly enabled, disabled, or not provided.