Revert "feat(base): add dashboard-arrange command and text block type support"

[zhouyue-bytedance]

Reverts #341

Summary by CodeRabbit

• Bug Fixes

  • Removed +dashboard-arrange command for automatic dashboard component rearrangement
  • Removed text (Markdown) block type support from dashboard components
  • Enhanced validation for dashboard block updates to better detect configuration errors

• Documentation

  • Updated dashboard command documentation and references to reflect removed features

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR removes the +dashboard-arrange command and support for text block type from dashboard operations. Changes include deleting the arrange command implementation file, removing related functions, updating validation logic for dashboard blocks, removing test cases, and updating documentation to reflect the reduced feature set.

Changes

Cohort / File(s)	Summary
Arrange Command Removal shortcuts/base/dashboard_arrange.go, shortcuts/base/dashboard_ops.go, shortcuts/base/shortcuts.go	Deleted the entire BaseDashboardArrange shortcut definition, removed executeDashboardArrange and dryRunDashboardArrange functions, and unregistered the command from the shortcuts list.
Text Block Type Removal shortcuts/base/dashboard_block_create.go, shortcuts/base/dashboard_block_update.go, shortcuts/base/helpers.go	Removed special-case validation for text type, deleted text-specific validation branch, and updated flag descriptions. Block creation now accepts empty data-config unconditionally.
Test Updates shortcuts/base/base_dashboard_execute_test.go, shortcuts/base/base_shortcuts_test.go	Deleted test cases for arrange operations and text block types; updated shortcut catalog test to remove +dashboard-arrange entry.
Documentation Updates skills/lark-base/references/dashboard-block-data-config.md, skills/lark-base/references/lark-base-dashboard-block-create.md, skills/lark-base/references/lark-base-dashboard.md, skills/lark-base/SKILL.md	Removed text component type from schema, deleted arrange command documentation page (lark-base-dashboard-arrange.md), and removed arrange references from main dashboard documentation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat(base): add dashboard-arrange command and text block type support #341: This PR directly reverses feature additions made by #341—both touch identical code points (dashboard_arrange.go, arrange handlers, text block validation) but in opposite directions (removal vs. addition).
• refactor(dashboard): restructure docs for AI-friendly navigation #191: Related through shared modifications to dashboard block command surface in dashboard_block_create.go and dashboard_block_update.go, updating flag documentation and validation logic.

Suggested labels

domain/base, size/M

Suggested reviewers

• liangshuo-1

Poem

🐰 With arrange now gone and text types away,
The dashboard grows leaner, more focused today!
Clean code, cleaner docs—a rabbit's delight,
Removing the clutter, keeping things right. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is minimal and lacks required sections from the template (Summary, Changes, Test Plan, Related Issues are mostly absent or incomplete).	Expand the description to include a summary of the revert, list the main changes being removed, describe the test plan, and properly reference the related issue with a Closes/Fixes link.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: reverting a previous feature that added dashboard-arrange command and text block type support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-341-base_dashboard

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR reverts #341, which had added a +dashboard-arrange command for auto-arranging dashboard block layouts and a text block type with Markdown support. All 13 changed files are consistently cleaned up: the dashboard_arrange.go implementation is deleted, BaseDashboardArrange is removed from shortcuts.go, the text type is dropped from the block-create/update descriptors, corresponding test cases are removed, and the associated skill/reference documentation (lark-base-dashboard-arrange.md) is deleted.

Confidence Score: 5/5

Safe to merge — this is a clean, consistent revert with no leftover references to the removed feature.

All 13 changed files are consistently reverted: the dashboard_arrange.go implementation is deleted, its shortcut is removed from registration and tests, text block type is dropped from create/update descriptors and docs, and no stale references remain anywhere in the codebase. No new logic is introduced; only previously added code is removed.

No files require special attention.

Important Files Changed

Filename	Overview
shortcuts/base/shortcuts.go	Removes BaseDashboardArrange from the Shortcuts() slice; the remaining shortcuts are intact and consistent with tests.
shortcuts/base/dashboard_block_create.go	Drops text from the --type enum description; core create logic and validation are unchanged from pre-#341 state.
shortcuts/base/dashboard_ops.go	Removes dryRunDashboardArrange / executeDashboardArrange functions; remaining dashboard CRUD ops unaffected.
shortcuts/base/base_shortcuts_test.go	Removes +dashboard-arrange from TestShortcutsCatalog; count and ordering still match Shortcuts().
shortcuts/base/base_dashboard_execute_test.go	Removes arrange-specific execute tests; remaining dashboard and block tests are complete and correct.
skills/lark-base/SKILL.md	Reverts arrange-related guidance; no stale +dashboard-arrange references remain in the file.
skills/lark-base/references/lark-base-dashboard.md	Removes arrange from the capability table and scenario workflows; consistent with deleted arrange reference doc.
skills/lark-base/references/dashboard-block-data-config.md	Removes text block type from the supported types table; all other type documentation unchanged.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["PR #341 (feat)"] -->|added| B["+dashboard-arrange command\n(dashboard_arrange.go)"]
    A -->|added| C["text block type\n(dashboard_block_create/update.go)"]
    A -->|added| D["lark-base-dashboard-arrange.md\n+ SKILL.md updates"]

    E["PR #386 (revert)"] -->|deletes| B
    E -->|reverts| C
    E -->|deletes| D
    E -->|updates| F["shortcuts.go\n(removes BaseDashboardArrange)"]
    E -->|updates| G["base_shortcuts_test.go\n(removes +dashboard-arrange from catalog)"]
    E -->|updates| H["base_dashboard_execute_test.go\n(removes arrange tests)"]
    E -->|updates| I["dashboard_ops.go\n(removes arrange ops)"]
    E -->|updates| J["helpers.go\n(removes arrange helpers)"]

    style E fill:#f9a825,color:#000
    style B fill:#ef5350,color:#fff
    style C fill:#ef5350,color:#fff
    style D fill:#ef5350,color:#fff

Loading

_{Reviews (1): Last reviewed commit: "Revert "Add `+dashboard-arrange` command..." | Re-trigger Greptile}

[github-actions]

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@499863bc3fb267f5db4a082186d581ed1118df76

🧩 Skill update

npx skills add larksuite/cli#revert-341-base_dashboard -y -g