Revert "Add client_secret to device authorization request (#517)"

[JackZhao10086]

This reverts commit 663c24a.

Summary

Changes

• Change 1
• Change 2

Test Plan

• Unit tests pass
• Manual local verification confirms the lark xxx command works as expected

Related Issues

• None

Summary by CodeRabbit

• Bug Fixes
  • Device authorization requests no longer include client_secret in the request body, ensuring compliance with device flow authentication standards.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4c9a54d8-5855-48f2-ad35-2e608ca57360

📥 Commits

Reviewing files that changed from the base of the PR and between be79485 and 445d6e5.

📒 Files selected for processing (2)

• internal/auth/device_flow.go
• internal/auth/device_flow_test.go

💤 Files with no reviewable changes (2)

• internal/auth/device_flow.go
• internal/auth/device_flow_test.go

---

📝 Walkthrough

Walkthrough

The device authorization request no longer includes the client_secret parameter in the form body. The corresponding test that verified this parameter's presence has been removed.

Changes

Cohort / File(s)	Summary
Device Authorization Request Update internal/auth/device_flow.go, internal/auth/device_flow_test.go	Removed client_secret parameter from the device authorization form request and deleted the associated test TestRequestDeviceAuthorization_ClientSecretInBody that verified the parameter was included in the POST body.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Add client_secret to device authorization request #517: Directly related—both PRs modify RequestDeviceAuthorization and its test regarding client_secret inclusion in the request body.

Poem

🐰 A secret once whispered in forms now takes flight,
Removed from the body, the request shines bright.
Trust blooms anew without hidden keys,
The device flows freely, at last at its ease! 🔐✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete with placeholder content; it contains template text ('Change 1', 'Change 2') instead of actual details about what was reverted and why.	Replace placeholder sections with specific details about why the revert was necessary and what functionality was removed. Fill in the Summary, Changes, and Test Plan sections with meaningful content.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: reverting a commit that added client_secret to device authorization requests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/revert_517

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.09%. Comparing base (be79485) to head (445d6e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   59.09%   59.09%   -0.01%     
==========================================
  Files         384      384              
  Lines       32673    32672       -1     
==========================================
- Hits        19308    19307       -1     
  Misses      11556    11556              
  Partials     1809     1809              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@445d6e56127fa8b5f55029e1e04c0b43d69add85

🧩 Skill update

npx skills add larksuite/cli#feat/revert_517 -y -g