Skip to content

feat: add remind/initiated method#554

Merged
MaxHuang22 merged 1 commit intolarksuite:mainfrom
Paulazaaza-dev:feat/approval-support-external
Apr 18, 2026
Merged

feat: add remind/initiated method#554
MaxHuang22 merged 1 commit intolarksuite:mainfrom
Paulazaaza-dev:feat/approval-support-external

Conversation

@Paulazaaza-dev
Copy link
Copy Markdown
Contributor

@Paulazaaza-dev Paulazaaza-dev commented Apr 18, 2026

Summary

Add features including query user-initiated list, remind approvers, and operate third-party document with quick callbacks.

Changes

  • Implement query for user-initiated approval list
  • Add reminder functionality for approval assignees
  • Support approve/reject operations for third-party documents with quick approval callback

Change-Id: I27c00d96a9478efbf39fbc1118bb6bcb75fe6b14
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 18, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size/M Single-domain feat or fix with limited business impact label Apr 18, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 18, 2026

📝 Walkthrough

Walkthrough

This PR extends the Lark approval skill documentation by adding two new CLI methods: instances.initiated for querying user-initiated approval instances and tasks.remind for reminding approvers, along with their corresponding permission mappings.

Changes

Cohort / File(s) Summary
Approval Skill Documentation
skills/lark-approval/SKILL.md
Added two new approval CLI methods (instances.initiated and tasks.remind) with permission mappings (approval:instance:read and approval:instance:write respectively) to the documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • feat: add approve domain #217: Extends the lark-approval skill with the same two new CLI methods (instances.initiated and tasks.remind) for approval workflow management.

Suggested labels

size/M

Suggested reviewers

  • MaxHuang22
  • liangshuo-1

Poem

🐰 Two new commands hop into view,
Approval workflows, fresh and true,
Initiated instances, reminders to send,
Documentation complete, the skill's on trend! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description provides a summary and lists changes, but lacks the 'Test Plan' and 'Related Issues' sections specified in the repository template. Add 'Test Plan' section with checkboxes (unit tests, manual verification) and 'Related Issues' section to complete the required template structure.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add remind/initiated method' clearly summarizes the main changes - adding two new methods to the lark-approval skill documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.91%. Comparing base (5a0e1d3) to head (d11fa4a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   59.91%   59.91%           
=======================================
  Files         388      388           
  Lines       33147    33147           
=======================================
  Hits        19859    19859           
  Misses      11420    11420           
  Partials     1868     1868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@d11fa4acb5e0640ce231b6e6c42a1d47513f4d88

🧩 Skill update

npx skills add Paulazaaza-dev/cli#feat/approval-support-external -y -g

@MaxHuang22 MaxHuang22 merged commit 5134719 into larksuite:main Apr 18, 2026
20 checks passed
@liangshuo-1 liangshuo-1 mentioned this pull request Apr 20, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants