docs: clarify that lark-drive comment listing defaults to unresolved comments only#609
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughDocumentation updates for Lark Drive: enforce Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…comments only Change-Id: Ie4200fe14f1e3c4735c1fcc4aba4a3f9a4900e22
999a1e3 to
0358c05
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skill-template/domains/drive.md`:
- Around line 131-133: The example title "查询所有评论" conflicts with the command
filter because the params include "is_solved": false (unresolved-only); update
the label to reflect unresolved comments or remove/adjust the is_solved
parameter so it actually queries all comments—locate the example in
skill-template/domains/drive.md and change the heading or the JSON param (the
is_solved field in the lark-cli drive file.comments list example) so the title
and the command semantics match.
In `@skills/lark-drive/SKILL.md`:
- Around line 144-146: Heading "查询所有评论(用户未明确要求包含已解决评论)" is inaccurate because
the example command includes "is_solved": false (unresolved-only); update the
label to reflect unresolved comments, e.g., change that heading to "查询未解决的评论" or
remove the is_solved filter from the command if you truly want "all comments";
target the heading text in SKILL.md and/or the example command to keep them
consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 86dfaa7a-5e65-420a-86b2-40f57821cfa0
📒 Files selected for processing (2)
skill-template/domains/drive.mdskills/lark-drive/SKILL.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@0358c05834674f42a9ae5942ff7f9a8c0759c2ba🧩 Skill updatenpx skills add larksuite/cli#docs/lark-drive-unresolved-comments-default -y -g |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 61.69% 59.94% -1.76%
==========================================
Files 402 405 +3
Lines 35073 42673 +7600
==========================================
+ Hits 21639 25580 +3941
- Misses 11429 15084 +3655
- Partials 2005 2009 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Change-Id: Ie4200fe14f1e3c4735c1fcc4aba4a3f9a4900e22
Summary
Clarifies that
drive file.comments listdefaults to unresolved comments only, and that callers must passis_solved:falseunless the user explicitly asks to include resolved comments. This reduces agent ambiguity and makes the intended default behavior easier to follow at execution time.Changes
skills/lark-drive/SKILL.mdthatdrive file.comments listshould default to unresolved comments onlyis_solved:falseusage and mirrored the rule next to thefile.comments listcommand entryTest Plan
lark xxxcommand works as expectedRelated Issues
Summary by CodeRabbit