Skip to content

test: align e2e --yes flags with high-risk-write meta data#701

Merged
liangshuo-1 merged 1 commit intolarksuite:mainfrom
yxzhaao:fix/e2e-risk-yes-alignment
Apr 28, 2026
Merged

test: align e2e --yes flags with high-risk-write meta data#701
liangshuo-1 merged 1 commit intolarksuite:mainfrom
yxzhaao:fix/e2e-risk-yes-alignment

Conversation

@yxzhaao
Copy link
Copy Markdown
Contributor

@yxzhaao yxzhaao commented Apr 28, 2026

Summary

Changes

  • Change 1
  • Change 2

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark xxx command works as expected

Related Issues

  • None

Summary by CodeRabbit

  • Tests
    • Calendar operations now include automatic confirmation in e2e tests for improved test reliability
    • Mail draft deletions standardized with automatic confirmation in cleanup workflows
    • Task operations updated for consistent confirmation behavior across e2e tests

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1b1781c6-a27c-4261-b8b3-e53f1a67355b

📥 Commits

Reviewing files that changed from the base of the PR and between 4422265 and 7ebf12b.

📒 Files selected for processing (7)
  • tests/cli_e2e/calendar/calendar_create_event_test.go
  • tests/cli_e2e/calendar/calendar_manage_calendar_test.go
  • tests/cli_e2e/calendar/calendar_update_event_test.go
  • tests/cli_e2e/mail/mail_draft_lifecycle_workflow_test.go
  • tests/cli_e2e/mail/mail_send_workflow_test.go
  • tests/cli_e2e/task/task_update_workflow_test.go
  • tests/cli_e2e/task/tasklist_workflow_test.go
💤 Files with no reviewable changes (2)
  • tests/cli_e2e/task/tasklist_workflow_test.go
  • tests/cli_e2e/task/task_update_workflow_test.go

📝 Walkthrough

Walkthrough

This PR modifies e2e tests across calendar, mail, and task modules to adjust CLI auto-confirmation behavior. Most changes add Yes: true to delete operations in cleanup paths, while two task-related tests remove the flag from patch operations, ensuring consistent confirmation handling during e2e execution.

Changes

Cohort / File(s) Summary
Calendar event & calendar management cleanup
tests/cli_e2e/calendar/calendar_create_event_test.go, tests/cli_e2e/calendar/calendar_manage_calendar_test.go
Added Yes: true to delete cleanup operations to auto-confirm calendar event and calendar deletion in e2e tests.
Calendar event update
tests/cli_e2e/calendar/calendar_update_event_test.go
Added Yes: true to both event cleanup deletion and explicit delete test step for auto-confirmation.
Mail draft cleanup deletions
tests/cli_e2e/mail/mail_draft_lifecycle_workflow_test.go, tests/cli_e2e/mail/mail_send_workflow_test.go
Added Yes: true to draft deletion cleanup operations to auto-confirm delete commands in e2e workflow tests.
Task patch operations
tests/cli_e2e/task/task_update_workflow_test.go, tests/cli_e2e/task/tasklist_workflow_test.go
Removed Yes: true flag from patch API/CLI requests, disabling auto-confirmation for task and tasklist patch operations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Feat/risk tiering #633: Both PRs modify CLI e2e tests to manage the Request.Yes confirmation flag for delete operations, reflecting confirmation gating behavior.
  • feat: add calendar update shortcut #678: Both PRs modify the calendar update event e2e test; this PR adjusts delete cleanup confirmation while the other introduced the test itself.

Suggested labels

domain/calendar, size/M

Suggested reviewers

  • liangshuo-1
  • hugang-lark
  • liuxinyanglxy

Poem

🐰 A rabbit hops through test suites with glee,
Confirming deletions, one, two, three!
With Yes: true flags placed just right,
Cleanup operations run smooth through the night. ✨
(But patches need no auto-affirmation's sight!)

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description uses placeholder text from the template without providing substantive details about the changes, motivation, or test verification. Replace placeholder text with actual summary, specific changes list, and completed test plan details explaining how the --yes flag alignment was verified.
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: aligning e2e test --yes flags with high-risk-write metadata across multiple test files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/S Low-risk docs, CI, test, or chore only changes label Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.80%. Comparing base (4422265) to head (7ebf12b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   63.80%   63.80%           
=======================================
  Files         500      500           
  Lines       43531    43531           
=======================================
  Hits        27773    27773           
  Misses      13317    13317           
  Partials     2441     2441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@7ebf12ba725ae6ec9d1a0e02ab7744e0374abf8e

🧩 Skill update

npx skills add yxzhaao/cli#fix/e2e-risk-yes-alignment -y -g

@liangshuo-1 liangshuo-1 merged commit 6bb988a into larksuite:main Apr 28, 2026
18 checks passed
HomyeeKing pushed a commit to HomyeeKing/cli that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Low-risk docs, CI, test, or chore only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants